Re: GSOC idea: build in scripts and cleanups

From: Jeff King <peff@peff.net>
Date: Apr 5, 2011, 16:52 UTC
Message-ID: <20110405165212.GB9965@sigill.intra.peff.net>
In-Reply-To: <201104040943.10030.robert.david.public@gmail.com>

On Mon, Apr 04, 2011 at 09:43:09AM +0200, Robert David wrote:

Show 6 quoted lines

> Today git code consists of the base written in C and many helper shell or PERL 
> scripts. While at a first time it is easier to write the script, final code is 
> supposed to be in C. One of these scripts is git-add--interactive.
> 
> Git-add--interactive is a helper script for git-add, which servers its options 
> -i and -p. It definitely need to be integrated in git-add.

Can you expand on "definitely" here? I.e., what are the motivations for this change? I know what some of the arguments are, and I know how _I_ would answer the question, but I want to hear what _you_ think.

And I am not just trying to be pedantic. Understanding the motivations for a change will help us figure out the right way to go about it, and how to figure out if we are successful at making it.

Show 5 quoted lines

> Interfaces
> As this is mainly part of git-add, that means that it will need to be changed 
> at the most.
> There are also another commands using this functionality now: git-am, git-
> checkout, git-rebase.

I don't think this is right. "am" and "rebase" have interactive modes, but the code and functionality are not shared at all with add--interactive. But you are missing some other commands that do have patch modes built on add--interactive.

-Peff