git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] format-patch: don't pass on the --quiet flag

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 12, 2011, 18:56 UTC
Message-ID
<7vk4ezpacr.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1302622538-7535-1-git-send-email-cmn@elego.de>
Carlos Martín Nieto <cmn@elego.de> writes:
Show 5 quoted lines
>> A patch to make --quiet not to squelch the patch output, and instead
>> silence any progress output would be a good addition.
>
> Something like this? I guess the only use case would be together with
> -o.

When the user gives -q without giving -o to a new or an empty directory, the user deserves to get what was asked on the command line, so I wouldn't worry about this particular case. For a casual user, it is perfectly a sensible thing to say "I'll eyeball; I don't have other files whose names begin with [0-9]{4}- in my working tree" and I don't think we need safety against doing that.

I however wonder if we should audit other commands in the "log" family to see what they do when "--quiet" is given. I know what they do currently is whatever they happen to do for a nonsense request, and in no way is a designed behaviour. We simply did never think about that case.

For example, what should "git show master^2 next^2" do with "--quiet"? Of course the standard way to squelch diff output in the output from "show" is to use "-s" (coming from "git diff-tree"), but giving "--quiet" should at least be a no-op.

Previous: Carlos Martín NietoNext: Carlos Martín Nieto
Message 8 of 17 in “Bug in "git diff --quiet" handling.”
  1. Paul GortmakerApr 11, 2011
  2. Junio C HamanoApr 11, 2011
  3. format-patch: don't pass on the --quiet flagCarlos Martín Nieto, Apr 12, 2011
  4. format-patch: document --quiet optionCarlos Martín Nieto, Apr 12, 2011
  5. Junio C HamanoApr 12, 2011
  6. Junio C HamanoApr 12, 2011
  7. Carlos Martín NietoApr 13, 2011
  8. Junio C HamanoApr 12, 2011
  9. Carlos Martín NietoApr 13, 2011
  10. whatchanged: always show the headerCarlos Martín Nieto, Apr 13, 2011
  11. Junio C HamanoApr 13, 2011
  12. Carlos Martín NietoApr 13, 2011
  13. log: convert to parse-optionsCarlos Martín Nieto, Apr 14, 2011
  14. Junio C HamanoApr 14, 2011
  15. log: convert to parse-options=?UTF-8?q?Carlos=20Mart=C3=ADn=20Nieto?=, Apr 19, 2011
  16. Jeff KingApr 20, 2011
  17. Carlos Martín NietoApr 20, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.