git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] log: convert to parse-options

From
Carlos Martín Nieto <cmn@elego.de>
Date
Apr 20, 2011, 14:51 UTC
Message-ID
<20110420145120.GC5236@bee.lab.cmartin.tk>
In-Reply-To
<20110420023817.GA14201@sigill.intra.peff.net>
On Tue, Apr 19, 2011 at 10:38:17PM -0400, Jeff King wrote:
Show 17 quoted lines
> On Tue, Apr 19, 2011 at 02:33:31PM +0200, =?UTF-8?q?Carlos=20Mart=C3=ADn=20Nieto?= wrote:
> 
> > Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
> 
> This is not about your patch at all, but rather that I notice in your
> "From" header that your name is doubly rfc2047-encoded. It looks like
> this:
> 
>   From: =?us-ascii?B?PT9VVEYtOD9xP0Nhcmxvcz0yME1hcnQ9QzM9QURuPTIwTmlldG8/?=
>     =?us-ascii?Q?=3D?= <cmn@elego.de>
> 
> which decodes to the literal string:
> 
>   =?UTF-8?q?Carlos=20Mart=C3=ADn=20Nieto?=
> 
> which in turn decodes again to your proper name.
> 
Ah, so that's what been going on.
Show 11 quoted lines
> We made some changes to format-patch's quoting recently, and I want to
> make sure this is not a regression. Can you describe your workflow for
> sending these patches? What I think probably happened is:
> 
>   1. format-patch encoded your name because of the non-ascii characters
> 
>   2. the result was fed literally into mutt via cut-and-paste or
>      otherwise pulled into the editor, rather than "mutt -f patch-file".
> 
> Which is not a regression, but just an annoying behavior that has been
> there for a while[1]. But I wanted to double-check.

As I was only sending one patch, I did what the intertubes suggested and used "mutt -H patch-file" which I guess that's the problem. I only noticed this because someone mentioned it, after I sent another patch.

So no regression, and a --leave-utf8-alone option would be useful here.
Cheers,
   cmn
Previous: Jeff King
Message 17 of 17 in “Bug in "git diff --quiet" handling.”
  1. Paul GortmakerApr 11, 2011
  2. Junio C HamanoApr 11, 2011
  3. format-patch: don't pass on the --quiet flagCarlos Martín Nieto, Apr 12, 2011
  4. format-patch: document --quiet optionCarlos Martín Nieto, Apr 12, 2011
  5. Junio C HamanoApr 12, 2011
  6. Junio C HamanoApr 12, 2011
  7. Carlos Martín NietoApr 13, 2011
  8. Junio C HamanoApr 12, 2011
  9. Carlos Martín NietoApr 13, 2011
  10. whatchanged: always show the headerCarlos Martín Nieto, Apr 13, 2011
  11. Junio C HamanoApr 13, 2011
  12. Carlos Martín NietoApr 13, 2011
  13. log: convert to parse-optionsCarlos Martín Nieto, Apr 14, 2011
  14. Junio C HamanoApr 14, 2011
  15. log: convert to parse-options=?UTF-8?q?Carlos=20Mart=C3=ADn=20Nieto?=, Apr 19, 2011
  16. Jeff KingApr 20, 2011
  17. Carlos Martín NietoApr 20, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.