Re: [PATCH] http_init: accept separate URL parameter
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 12, 2011, 22:38 UTC
- Message-ID
- <7vk4897s4c.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20111012214610.GA4578@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 10 quoted lines
> On Wed, Oct 12, 2011 at 05:43:16PM -0400, Jeff King wrote: > ... >> Instead, let's just add a separate URL parameter to >> http_init, and all three callsites can pass in the >> appropriate information. >> >> Signed-off-by: Jeff King <peff@peff.net> > > Sorry, I forgot to mention: this is meant to go on top of the > http-auth-keyring topic.
Hmm, of course the patch was written to help http-auth-keyring topic, but wouldn't this be an improvement that is general enough? I.e. it could even go to the bottom of the topic, no?