Re: [PATCH] http_init: accept separate URL parameter
- From
Jeff King <peff@peff.net>
- Date
- Oct 12, 2011, 22:46 UTC
- Message-ID
- <20111012224625.GA11408@sigill.intra.peff.net>
- In-Reply-To
- <7vk4897s4c.fsf@alter.siamese.dyndns.org>
On Wed, Oct 12, 2011 at 03:38:27PM -0700, Junio C Hamano wrote:
Show 16 quoted lines
> Jeff King <peff@peff.net> writes: > > > On Wed, Oct 12, 2011 at 05:43:16PM -0400, Jeff King wrote: > > ... > >> Instead, let's just add a separate URL parameter to > >> http_init, and all three callsites can pass in the > >> appropriate information. > >> > >> Signed-off-by: Jeff King <peff@peff.net> > > > > Sorry, I forgot to mention: this is meant to go on top of the > > http-auth-keyring topic. > > Hmm, of course the patch was written to help http-auth-keyring topic, but > wouldn't this be an improvement that is general enough? I.e. it could > even go to the bottom of the topic, no?
Yes, it could, and probably should. I suspect it might need some rebasing to do that.
I'm going to float some other possible designs for the topic as soon as I put enough polish on them. So I'll try to move this down when I re-roll. In the meantime, if you want to throw it on top, great. If you want to ignore it until then, no problem. :)
-Peff