Re: [PATCHv2 3/8] gitweb: Faster project search

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 20, 2012, 08:33 UTC
Message-ID: <7vk43hnbt7.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1329338332-30358-4-git-send-email-jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

> Before searching by some field the information we search for must be
> filled in.  For this fill_project_list_info() was enhanced in previous
> commit to take additional parameters which part of projects info to

"must be filled in." is correct, but that happens without the previous patch. The first sentence must also say:

	In order to search by some field, the information we look for must
	be filled in, but we do not have to fill other fields that are not
	involved in the search.

to justify the previous "fill_project_list_info can be asked to return without getting unused fields" patch. The rest of the log message then makes good sense.

Show 10 quoted lines

> fill.  This way we can limit doing expensive calculations (like
> running git-for-each-ref to get 'age' / "Last changed" info) only to
> projects which we will show as search results.
>
> With this commit the number of git commands used to generate search
> results is 2*<matched projects> + 1, and depends on number of matched
> projects rather than number of all projects (all repositories).
>
> Note: this is 'git for-each-ref' to find last activity, and 'git config'
> for each project, and 'git --version' once.