[PATCHv2 2/8] gitweb: Option for filling only specified info in fill_project_list_info
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Feb 15, 2012, 20:38 UTC
- Message-ID
- <1329338332-30358-3-git-send-email-jnareb@gmail.com>
- In-Reply-To
- <1329338332-30358-1-git-send-email-jnareb@gmail.com>
Introduce project_info_needs_filling($pr, $key[, \%fill_only]), which is now used in place of simple 'defined $pr->{$key}' to check if specific slot in project needs to be filled.
This is in preparation of future lazy filling of project info in project search and pagination of sorted list of projects. The only functional change is that fill_project_list_info() now checks if 'age' is already filled before running git_get_last_activity().
Signed-off-by: Jakub Narebski <jnareb@gmail.com> --- This could have been squashed with the next commit, but this way it is pure refactoring that shouldn't change gitweb behavior.
Changes from v1: * Introduction of project_info_needs_filling() was moved to separate commit; this one just adds @fill_only / %fill_only, without actually using it.
* It uses \%fill_only (reference to hash) rather than @fill_only, because project_info_needs_filling() now supports multiple keys, and because checking key in hash is faster O(1) than checking every element in array O(n).
Though this shouldn't matter much, as @fill_only has at most two or three elements, as we would see in the next commit.
gitweb/gitweb.perl | 34 +++++++++++++++++++++++----------- 1 files changed, 23 insertions(+), 11 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index e62c2ef..cae71f5 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -5195,54 +5195,66 @@ sub git_project_search_form { print "</div>\n"; } -# entry for given @keys needs filling if at least one of keys in list -# is not present in %$project_info + +# entry for given @keys needs filling if at least one of interesting keys +# in list is not present in %$project_info; key is interesting if $fill_only +# is not passed, or is empty (all keys are interesting in both of those cases), +# or if key is in $fill_only hash +# +# USAGE: +# * project_info_needs_filling($project_info, 'key', ...) +# * project_info_needs_filling($project_info, 'key', ..., \%fill_only) +# where %fill_only = map { $_ => 1 } @fill_only; sub project_info_needs_filling { + my $fill_only = ref($_[-1]) ? pop : undef; my ($project_info, @keys) = @_; # return List::MoreUtils::any { !exists $project_info->{$_} } @keys; foreach my $key (@keys) { - if (!exists $project_info->{$key}) { + if ((!$fill_only || !%$fill_only || $fill_only->{$key}) && + !exists $project_info->{$key}) { return 1; } } return; } - # fills project list info (age, description, owner, category, forks) # for each project in the list, removing invalid projects from -# returned list +# returned list, or fill only specified info (removing invalid projects +# only when filling 'age'). +# # NOTE: modifies $projlist, but does not remove entries from it sub fill_project_list_info { - my $projlist = shift; + my ($projlist, @fill_only) = @_; + my %fill_only = map { $_ => 1 } @fill_only; my @projects; my $show_ctags = gitweb_check_feature('ctags'); PROJECT: foreach my $pr (@$projlist) { - if (project_info_needs_filling($pr, 'age', 'age_string')) { + if (project_info_needs_filling($pr, 'age', 'age_string', \%fill_only)) { my (@activity) = git_get_last_activity($pr->{'path'}); unless (@activity) { next PROJECT; } ($pr->{'age'}, $pr->{'age_string'}) = @activity; } - if (project_info_needs_filling($pr, 'descr', 'descr_long')) { + if (project_info_needs_filling($pr, 'descr', 'descr_long', \%fill_only)) { my $descr = git_get_project_description($pr->{'path'}) || ""; $descr = to_utf8($descr); $pr->{'descr_long'} = $descr; $pr->{'descr'} = chop_str($descr, $projects_list_description_width, 5); } - if (project_info_needs_filling($pr, 'owner')) { + if (project_info_needs_filling($pr, 'owner', \%fill_only)) { $pr->{'owner'} = git_get_project_owner("$pr->{'path'}") || ""; } if ($show_ctags && - project_info_needs_filling($pr, 'ctags')) { + project_info_needs_filling($pr, 'ctags', \%fill_only)) { $pr->{'ctags'} = git_get_project_ctags($pr->{'path'}); } if ($projects_list_group_categories && - project_info_needs_filling($pr, 'category')) { + project_info_needs_filling($pr, 'category', \%fill_only)) { my $cat = git_get_project_category($pr->{'path'}) || $project_list_default_category; $pr->{'category'} = to_utf8($cat);
-- 1.7.9