git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] branch: don't assume the merge filter ref exists

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 27, 2012, 19:33 UTC
Message-ID
<7vk4386pgi.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20120227193044.GD1600@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 6 quoted lines
> You would also get NULL if the object exists but is not a commit. Maybe:
>
>   die("object '%s' does not point to a commit", ...)
>
> would be better? It covers the wrong-type case, and is still technically
> true when the object does not exist.

For this particular message I like the above a lot better. The output from "git grep -e 'invalid object' -e 'bad object'" seems to show that the use of both are fairly evenly distributed.

Previous: Jeff KingNext: Jeff King
Message 5 of 8 in “[BUG] git branch --merged $unknown_checksum segfaults”
  1. Bernhard Reutner-FischerFeb 27, 2012
  2. branch: don't assume the merge filter ref existsCarlos Martín Nieto, Feb 27, 2012
  3. Junio C HamanoFeb 27, 2012
  4. Jeff KingFeb 27, 2012
  5. Junio C HamanoFeb 27, 2012
  6. Jeff KingFeb 27, 2012
  7. Carlos Martín NietoFeb 28, 2012
  8. Junio C HamanoFeb 28, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.