From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 27 Feb 2012 19:33:49 GMT
Subject: Re: [PATCH] branch: don't assume the merge filter ref exists
Message-ID: <7vk4386pgi.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120227193044.GD1600@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> You would also get NULL if the object exists but is not a commit. Maybe:
>
>   die("object '%s' does not point to a commit", ...)
>
> would be better? It covers the wrong-type case, and is still technically
> true when the object does not exist.

For this particular message I like the above a lot better.  The output
from "git grep -e 'invalid object' -e 'bad object'" seems to show that
the use of both are fairly evenly distributed.