git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] cleanup argument passing in submodule status command

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 29, 2012, 21:57 UTC
Message-ID
<7vk3xmut63.fsf@alter.siamese.dyndns.org>
In-Reply-To
<501556CF.1000605@web.de>
Jens Lehmann <Jens.Lehmann@web.de> writes:
Show 26 quoted lines
> I tried today. Before this change no arguments got passed down and
> afterwards they are (but just the arguments, no submodule paths
> were passed on in either case; which is what Kevin fixed in the
> commit Heiko referenced). Three arguments are allowed for "git
> submodule status":
>
> --recursive:
> It doesn't matter if we pass that on or not because $recursive is
> reused when "eval cmd_status" is executed.
>
> --quiet:
> Same as recursive, GIT_QUIET is set the first time and then reused
> in the recursion.
>
> --cached:
> This was dropped when recursing into submodules but isn't anymore
> with Heiko's change, so we do have a change in behavior here.
> ...
> Hmm, when --cached is used together with --recursive, I would expect
> it to show the commit stored in the index for the deeper submodules
> too (and not magically switch to show their HEAD again after the
> first level of submodules). To me this looks like a bug which Kevin
> accidentally introduced and nobody noticed and/or reported until now.
>
> So I'd vote for making this a bugfix patch for "git submodule status
> --cached --recursive" (and would love to see a test for it ;-).

Yeah, I am not opposed to a "fix". I just wanted it to be labelled as such, and analysed correctly.

And with test ;-)
Thanks.
Previous: Jens LehmannNext: Jens Lehmann
Message 7 of 12 in “Enable parallelism in git submodule update.”
  1. Enable parallelism in git submodule update.Stefan Zager, Jul 27, 2012
  2. Junio C HamanoJul 27, 2012
  3. Heiko VoigtJul 28, 2012
  4. cleanup argument passing in submodule status commandHeiko Voigt, Jul 28, 2012
  5. Junio C HamanoJul 29, 2012
  6. Jens LehmannJul 29, 2012
  7. Junio C HamanoJul 29, 2012
  8. Jens LehmannJul 29, 2012
  9. Jens LehmannNov 3, 2012
  10. Junio C HamanoJul 27, 2012
  11. Heiko VoigtJul 28, 2012
  12. Junio C HamanoJul 29, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.