git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] cleanup argument passing in submodule status command

From
Heiko Voigt <hvoigt@hvoigt.net>
Date
Jul 28, 2012, 12:19 UTC
Message-ID
<20120728121956.GA36429@book.hvoigt.net>
In-Reply-To
<20120728102209.GA13370@book.hvoigt.net>

In commit 98dbe63 the variable $orig_args was renamed to $orig_flags. One location in cmd_status() was missed.

Note: This is a code cleanup and does not fix any bugs. As a side effect
the variables containing the parsed flags to "git submodule status" are
passed down recursively. So everything was already behaving as expected.
Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
---
 git-submodule.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index dba4d39..3a3f0a4 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -961,7 +961,7 @@ cmd_status()
 				prefix="$displaypath/"
 				clear_local_git_env
 				cd "$sm_path" &&
-				eval cmd_status "$orig_args"
+				eval cmd_status "$orig_flags"
 			) ||
 			die "$(eval_gettext "Failed to recurse into submodule path '\$sm_path'")"
 		fi
-- 
1.7.12.rc0.23.g3c7cae0
Previous: Heiko VoigtNext: Junio C Hamano
Message 4 of 12 in “Enable parallelism in git submodule update.”
  1. Enable parallelism in git submodule update.Stefan Zager, Jul 27, 2012
  2. Junio C HamanoJul 27, 2012
  3. Heiko VoigtJul 28, 2012
  4. cleanup argument passing in submodule status commandHeiko Voigt, Jul 28, 2012
  5. Junio C HamanoJul 29, 2012
  6. Jens LehmannJul 29, 2012
  7. Junio C HamanoJul 29, 2012
  8. Jens LehmannJul 29, 2012
  9. Jens LehmannNov 3, 2012
  10. Junio C HamanoJul 27, 2012
  11. Heiko VoigtJul 28, 2012
  12. Junio C HamanoJul 29, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.