Re: [PATCH] t7811 (grep-open): remove test_config() redefinition

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 19, 2013, 16:09 UTC
Message-ID: <7vk3p3jrrw.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1363689794-25974-1-git-send-email-artagnon@gmail.com>

Ramkumar Ramachandra <artagnon@gmail.com> writes:

> test_config() is already a well-defined function in
> test-lib-functions.sh.  Don't duplicate it unnecessarily.

There are other instances of it in t7810 and t4018, with slightly different styles.

t/t4018-diff-funcname.sh:test_config () { t/t7810-grep.sh:test_config() { t/t7811-grep-open.sh:test_config() { t/test-lib-functions.sh:test_config () {

Incidentally, this is why a consistent coding style helps. It should be possible to catch all ofhtme with a single

	git grep 'test_config () {' t/

but the ones in t78xx wouldn't have been found.

Show 23 quoted lines

> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
> ---
>  Found this while randomly grep'ping around.
>
>  t/t7811-grep-open.sh | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/t/t7811-grep-open.sh b/t/t7811-grep-open.sh
> index a895778..e1951a5 100755
> --- a/t/t7811-grep-open.sh
> +++ b/t/t7811-grep-open.sh
> @@ -125,11 +125,6 @@ test_expect_success 'modified file' '
>  	test_cmp empty out
>  '
>  
> -test_config() {
> -	git config "$1" "$2" &&
> -	test_when_finished "git config --unset $1"
> -}
> -
>  test_expect_success 'copes with color settings' '
>  	rm -f actual &&
>  	echo grep.h >expect &&