git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t7811 (grep-open): remove test_config() redefinition

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
Mar 19, 2013, 10:43 UTC
Message-ID
<1363689794-25974-1-git-send-email-artagnon@gmail.com>

test_config() is already a well-defined function in test-lib-functions.sh. Don't duplicate it unnecessarily.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 Found this while randomly grep'ping around.
 t/t7811-grep-open.sh | 5 -----
 1 file changed, 5 deletions(-)
diff --git a/t/t7811-grep-open.sh b/t/t7811-grep-open.sh
index a895778..e1951a5 100755
--- a/t/t7811-grep-open.sh
+++ b/t/t7811-grep-open.sh
@@ -125,11 +125,6 @@ test_expect_success 'modified file' '
 	test_cmp empty out
 '
 
-test_config() {
-	git config "$1" "$2" &&
-	test_when_finished "git config --unset $1"
-}
-
 test_expect_success 'copes with color settings' '
 	rm -f actual &&
 	echo grep.h >expect &&
-- 
1.8.2
Next: Junio C Hamano
Message 1 of 6 in “t7811 (grep-open): remove test_config() redefinition”
  1. t7811 (grep-open): remove test_config() redefinitionRamkumar Ramachandra, Mar 19, 2013
  2. Junio C HamanoMar 19, 2013
  3. t: don't redefine test_config() in various placesRamkumar Ramachandra, Mar 20, 2013
  4. Jonathan NiederMar 20, 2013
  5. Junio C HamanoMar 20, 2013
  6. Ramkumar RamachandraMar 20, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.