git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/6] t/send-email.sh: add test for suppress-cc=self

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 3, 2013, 16:19 UTC
Message-ID
<7vk3mbi2u2.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1369897638-27299-2-git-send-email-mst@redhat.com>
"Michael S. Tsirkin" <mst@redhat.com> writes:
Show 25 quoted lines
> This adds a basic test for --suppress-cc=self
> option of git send-email.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  t/t9001-send-email.sh | 43 +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
>
> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
> index ebd5c5d..e1a7f3e 100755
> --- a/t/t9001-send-email.sh
> +++ b/t/t9001-send-email.sh
> @@ -171,6 +171,49 @@ Result: OK
>  EOF
>  "
>  
> +test_suppress_self () {
> +	test_commit $3 &&
> +	test_when_finished "git reset --hard HEAD^" &&
> +
> +	write_script cccmd-sed <<-EOF &&
> +		sed -n -e s/^cccmd--//p "\$1"
> +	EOF
> +
> +	git commit --amend --author="$1 <$2>" -F - &&  

Ahh, this helper reads the log message from its standard input; nice.

Show 37 quoted lines
> +	clean_fake_sendmail &&  
> +	git format-patch --stdout -1 >"suppress-self-$3.patch" &&  
> +
> +	git send-email --from="$1 <$2>" \
> +		--to=nobody@example.com \
> +		--cc-cmd=./cccmd-sed \
> +		--suppress-cc=self \
> +		--smtp-server="$(pwd)/fake.sendmail" \
> +		suppress-self-$3.patch &&
> +
> +	mv msgtxt1 msgtxt1-$3 &&
> +	sed -e '/^$/q' msgtxt1-$3 >"msghdr1-$3" &&
> +	>"expected-no-cc-$3" &&
> +
> +	(grep '^Cc:' msghdr1-$3 >"actual-no-cc-$3";
> +	 test_cmp expected-no-cc-$3 actual-no-cc-$3)
> +}
> +
> +test_suppress_self_unquoted () {
> +	test_suppress_self "$1" "$2" "unquoted-$3" <<-EOF
> +		test suppress-cc.self unquoted-$3 with name $1 email $2
> +
> +		unquoted-$3
> +
> +		Cc: $1 <$2>
> +		Signed-off-by: $1 <$2>
> +	EOF
> +}
> +
> +test_expect_success $PREREQ 'self name is suppressed' "
> +	test_suppress_self_unquoted 'A U Thor' 'author@redhat.com' \
> +		'self_name_suppressed'
> +"
> +
>  test_expect_success $PREREQ 'Show all headers' '
>  	git send-email \
>  		--dry-run \
Previous: Michael S. TsirkinNext: Michael S. Tsirkin
Message 3 of 18 in “git send-email suppress-cc=self fixes”
  1. 0/6 git send-email suppress-cc=self fixesMichael S. Tsirkin, May 30, 2013
  2. 1/6 t/send-email.sh: add test for suppress-cc=selfMichael S. Tsirkin, May 30, 2013
  3. Junio C HamanoJun 3, 2013
  4. 2/6 send-email: fix suppress-cc=self on cccmdMichael S. Tsirkin, May 30, 2013
  5. Junio C HamanoJun 3, 2013
  6. Michael S. TsirkinJun 3, 2013
  7. Junio C HamanoJun 3, 2013
  8. Michael S. TsirkinJun 3, 2013
  9. Junio C HamanoJun 3, 2013
  10. 3/6 t/send-email: test suppress-cc=self on cccmdMichael S. Tsirkin, May 30, 2013
  11. 4/6 send-email: make --suppress-cc=self sanitize inputMichael S. Tsirkin, May 30, 2013
  12. Junio C HamanoJun 3, 2013
  13. Michael S. TsirkinJun 3, 2013
  14. Junio C HamanoJun 3, 2013
  15. 5/6 t/send-email: add test with quoted senderMichael S. Tsirkin, May 30, 2013
  16. 6/6 t/send-email: test suppress-cc=self with non-asciiMichael S. Tsirkin, May 30, 2013
  17. Junio C HamanoJun 3, 2013
  18. Michael S. TsirkinJun 3, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.