Re: [PATCH v2 2/6] send-email: fix suppress-cc=self on cccmd

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 3, 2013, 15:58 UTC
Message-ID: <7v7gibjieh.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1369897638-27299-3-git-send-email-mst@redhat.com>

"Michael S. Tsirkin" <mst@redhat.com> writes:

Show 19 quoted lines

> When cccmd is used, old-style suppress-from filter
> is applied by the newer suppress-cc=self isn't.
> Fix this up.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  git-send-email.perl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index bd13cc8..a138615 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -1462,7 +1462,7 @@ sub recipients_cmd {
>  		$address =~ s/^\s*//g;
>  		$address =~ s/\s*$//g;
>  		$address = sanitize_address($address);
> -		next if ($address eq $sanitized_sender and $suppress_from);
> +		next if ($address eq $sender and $suppress_cc{'self'});

If $suppress_from is defined, $suppress_cc{'self'} gets its value, so the latter half of this change is very understandable.

The original comparison uses $address that is "sanitized" (whose definition is roughly "mangled/quoted with rfc2047 etc to fit on To/Cc headers") against $sanitized_sender, which means for a

    $sender = 'Michael S. Tsirkin <mst@redhat.com>';

we used

    $sanitized_sender = '"Michael S. Tsirkin" <mst@redhat.com>';

for comparison, but the new code does not quote the $recipient_name part inside dq for the single dot after the middle name. Is this a desirable change?

>  		push @addresses, $address;
>  		printf("($prefix) Adding %s: %s from: '%s'\n",
>  		       $what, $address, $cmd) unless $quiet;