Re: [PATCH] cg-fetch will now retrieve commits related to tags if missing.

From: Junio C Hamano <junkio@cox.net>
Date: Oct 20, 2005, 04:44 UTC
Message-ID: <7virvsu79c.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <46a038f90510192118s31c52fe7m73d88a9779653f4c@mail.gmail.com>

Martin Langhoff <martin.langhoff@gmail.com> writes:

Show 5 quoted lines

>>         GIT_DIR=../.. git-rev-parse --verify "$tagid^0" >/dev/null 2>&1 && continue
>
> Note however that git-rev-parse is lazy and won't check that the
> commit is there. I have to call git-cat-file and check whether it
> succeeds to know if we have the object.

Are you sure?

What "rev^0" does is:

    1. parse "rev"; make sure it can deref to commit and read
       it (otherwise give up and say the whole thing is not an
       SHA1 expression);

    2. grab the nth parent SHA1.  If N>0, it is lazy and does
       not check if the parent object exists, but still 0th
       parent is the commit object itself and if we came this
       far you know that commit is available already.

Together with --verify, it barfs if the above does not say "rev^0" is a valid SHA1 expression. So this should work without cat-file. No?

BTW, I just got a SEGV while pulling Cogito repository over git-fetch-pack after interrupting rsync transfer (I wanted to switch to git transfer). I am running with Johaness patch from today so the cause may be different from yours, but now I have something to look at, which is better than before.

Fetching with rsync (and interrupting in the middle) is a good way to simulate a broken repository ;-).