Re: [PATCH] cg-fetch will now retrieve commits related to tags if missing.

From: Martin Langhoff <martin.langhoff@gmail.com>
Date: Oct 20, 2005, 04:59 UTC
Message-ID: <46a038f90510192159h25aad025kf377e3e33b5d30d@mail.gmail.com>
In-Reply-To: <7virvsu79c.fsf@assigned-by-dhcp.cox.net>

On 10/20/05, Junio C Hamano <junkio@cox.net> wrote:

Show 11 quoted lines

> Martin Langhoff <martin.langhoff@gmail.com> writes:
>
> >>         GIT_DIR=../.. git-rev-parse --verify "$tagid^0" >/dev/null 2>&1 && continue
> >
> > Note however that git-rev-parse is lazy and won't check that the
> > commit is there. I have to call git-cat-file and check whether it
> > succeeds to know if we have the object.
>
> Are you sure?
>
> What "rev^0" does is:

Ok -- I was using ^{commit} which _is_ lazy, but you are right, ^0 isn't lazy.

Show 8 quoted lines

> BTW, I just got a SEGV while pulling Cogito repository over
> git-fetch-pack after interrupting rsync transfer (I wanted to
> switch to git transfer).  I am running with Johaness patch from
> today so the cause may be different from yours, but now I have
> something to look at, which is better than before.
>
> Fetching with rsync (and interrupting in the middle) is a good
> way to simulate a broken repository ;-).

Cool. That's something for you to play with I guess, to tell you the truth, I'm not useful with gdb ;)

martin