Re: Incremental cvsimports

From: Junio C Hamano <junkio@cox.net>
Date: May 24, 2006, 17:05 UTC
Message-ID: <7virnv8ib0.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060524135828.GA23934@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Odd. It's either a bug with importing tags in older versions, or there's
> some deep perl voodoo that I don't understand (either way, it is "fixed"
> in more recent versions).  Importing ENOENT directly is reasonable.

Sounds good. Thanks for the back-and-forth helping others in the community. I appreciate it.

> Junio, can you apply the following fix?

Will do, but I would have preferred if you did the commit log message and the stuff properly. Less work for me ;-).

Show 14 quoted lines

>
> diff --git a/git-cvsimport.perl b/git-cvsimport.perl
> index af331d9..76f6246 100755
> --- a/git-cvsimport.perl
> +++ b/git-cvsimport.perl
> @@ -23,7 +23,7 @@ use File::Basename qw(basename dirname);
>  use Time::Local;
>  use IO::Socket;
>  use IO::Pipe;
> -use POSIX qw(strftime dup2 :errno_h);
> +use POSIX qw(strftime dup2 ENOENT);
>  use IPC::Open2;
>  
>  $SIG{'PIPE'}="IGNORE";