Re: Incremental cvsimports

From: Jeff King <peff@peff.net>
Date: May 24, 2006, 13:58 UTC
Message-ID: <20060524135828.GA23934@coredump.intra.peff.net>
In-Reply-To: <93c3eada0605240647i48db0588ja343e348f5feb08e@mail.gmail.com>

On Wed, May 24, 2006 at 11:17:32PM +0930, Geoff Russell wrote:

Show 6 quoted lines

> All 3 work.  But if I add a second tag before the ':errno_h", then I
> get an error.
> 
> The "use" line that makes git-cvsimport compile for me is:
> 
>        use POSIX qw(strftime dup2 ENOENT);

Odd. It's either a bug with importing tags in older versions, or there's some deep perl voodoo that I don't understand (either way, it is "fixed" in more recent versions). Importing ENOENT directly is reasonable.

Junio, can you apply the following fix?

diff --git a/git-cvsimport.perl b/git-cvsimport.perl
index af331d9..76f6246 100755
--- a/git-cvsimport.perl
+++ b/git-cvsimport.perl
@@ -23,7 +23,7 @@ use File::Basename qw(basename dirname);
 use Time::Local;
 use IO::Socket;
 use IO::Pipe;
-use POSIX qw(strftime dup2 :errno_h);
+use POSIX qw(strftime dup2 ENOENT);
 use IPC::Open2;
 
 $SIG{'PIPE'}="IGNORE";