Re: [PATCH] Fail softly if file system does not like test data.

From: Junio C Hamano <junkio@cox.net>
Date: Jan 31, 2007, 22:17 UTC
Message-ID: <7viremu9gw.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200701310110.04429.robin.rosenberg.lists@dewire.com>

Your patch does not seem to apply. I wonder if the test path needs to be that looooooooooooong to begin with.

One thing I noticed on Cygwin is that from inside Cygwin environment t/trash directory becomes unremovable after the original test fails.

I am wondering what use it would be to have ISO-8859-1 pathnames in our test. As far as the test is concerned I think the point is to try non-ASCII paths, so I suspect this patch might be less of an impact.

Sorry for sending an attachement but in this case the patch text is _not_ in any particular encoding (the preimage is ISO-8859-1 but the postimage is in UTF-8) and transferring it as a textual patch over e-mail is not possible without a way to annotate each line which encoding it is in.

diff --git a/t/t9200-git-cvsexportcommit.sh b/t/t9200-git-cvsexportcommit.sh
index fd0a554..cc0a254 100755
--- a/t/t9200-git-cvsexportcommit.sh
+++ b/t/t9200-git-cvsexportcommit.sh
@@ -169,19 +169,19 @@ test_expect_success \
       test "$(echo $(sort "G g/CVS/Entries"|cut -d/ -f2,3,5))" = "with spaces.png/1.2/-kb with spaces.txt/1.2/"
       )'
 
-# This test contains ISO-8859-1 characters
+# This test contains UTF-8 characters
 test_expect_success \
      'File with non-ascii file name' \
-     'mkdir -p �/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/�/�/� &&
-      echo Foo >�/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/�/�/�/g�rdets�g�rdet.txt &&
-      git add �/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/�/�/�/g�rdets�g�rdet.txt &&
-      cp ../test9200a.png �/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/�/�/�/g�rdets�g�rdet.png &&
-      git add �/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/�/�/�/g�rdets�g�rdet.png &&
-      git commit -a -m "G�r det s� g�r det" && \
+     'mkdir -p ��/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/��/��/�� &&
+      echo Foo >��/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/��/��/��/g��rdets��g��rdet.txt &&
+      git add ��/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/��/��/��/g��rdets��g��rdet.txt &&
+      cp ../test9200a.png ��/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/��/��/��/g��rdets��g��rdet.png &&
+      git add ��/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/��/��/��/g��rdets��g��rdet.png &&
+      git commit -a -m "G��r det s�� g��r det" && \
       id=$(git rev-list --max-count=1 HEAD) &&
       (cd "$CVSWORK" &&
       git-cvsexportcommit -v -c $id &&
-      test "$(echo $(sort �/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/�/�/�/CVS/Entries|cut -d/ -f2,3,5))" = "g�rdets�g�rdet.png/1.1/-kb g�rdets�g�rdet.txt/1.1/"
+      test "$(echo $(sort ��/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/��/��/��/CVS/Entries|cut -d/ -f2,3,5))" = "g��rdets��g��rdet.png/1.1/-kb g��rdets��g��rdet.txt/1.1/"
       )'
 
 test_expect_success \