Re: [PATCH] Fail softly if file system does not like test data.

From: Brian Gernhardt <benji@silverinsanity.com>
Date: Jan 30, 2007, 23:28 UTC
Message-ID: <64949F2D-6A6D-4373-8B7F-C8F75529CD2E@silverinsanity.com>
In-Reply-To: <20070130224446.28311.31828.stgit@lathund.dewire.com>

On Jan 30, 2007, at 5:49 PM, Robin Rosenberg wrote:

Show 17 quoted lines

> Most unix file system allow almost any byte sequence, but other may  
> reject
> sequences that are not valid according to the locale. This change  
> makes
> failure somewhat less likely by using UTF-8-encoded characters (which
> happen to be valid interpreted as ISO-8859-1 and skips the test if the
> local file system does not support the test data.
>
> Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
> ---
>
> Please try this on cygwin (western iso-8859-X, korean on FAT &  
> NTFS) and
> MacOSX (HFS) where we know there was a problem. The non-ascii filename
> test should be skipped, with a notice) in most asian locales on  
> Windows
> and MacOSX.

Doesn't work, but it's closer. I can't see where a .gitignore is getting set, though.

* expecting success: (mkdir -p "å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/ 
q/r/s/t/u/v/w/x/y/z/å/ä/ö" ||
          echo "Local filesystem does not permit this test" ) &&
          echo Foo >"å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/ 
v/w/x/y/z/å/ä/ö/gårdetsågårdet.txt" &&
          git add "å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/ 
w/x/y/z/å/ä/ö/gårdetsågårdet.txt" &&
          cp ../test9200a.png "å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/ 
q/r/s/t/u/v/w/x/y/z/å/ä/ö/gårdetsågårdet.png" &&
          git add "å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/ 
w/x/y/z/å/ä/ö/gårdetsågårdet.png" &&
          git commit -a -m "Går det så går det" && \
          id=$(git rev-list --max-count=1 HEAD) &&
          (cd "$CVSWORK" &&
          git-cvsexportcommit -v -c $id &&
          test "$(echo $(sort "å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/ 
q/r/s/t/u/v/w/x/y/z/å/ä/ö/CVS/Entries"|cut -d/ -f2,3,5))" =  
"gårdetsågårdet.png/1.1/-kb gårdetsågårdet.txt/1.1/"
          )
The following paths are ignored by one of your .gitignore files:
å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/å/ä/ö/ 
gårdetsågårdet.txt
Use -f if you really want to add them.
* FAIL 8: File with non-ascii file name