Re: [PATCH] git-commit: exit non-zero if we fail to commit the index

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 17, 2008, 01:13 UTC
Message-ID: <7vir1tmey8.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <478E9C59.9070008@nrlssc.navy.mil>

Brandon Casey <casey@nrlssc.navy.mil> writes:

Show 7 quoted lines

> Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
> ---
>
>
> Shouldn't we be doing this? I think if quiet is set,
> then a failed rename will go undetected since we
> won't enter print_summary to have lookup_commit fail.

But then it's a bit too late, isn't it? We already have successfully made the commit and updated the HEAD to point at it. We would need to tell the user that the index is not where it is when we detect the error, though.

> run_hook also is not checked for failure.

I think you mean the final post-commit one, but that is deliberate. post-commit is not meant to affect the outcome of the command.