Re: [PATCH] git-commit: exit non-zero if we fail to commit the index

From: Brandon Casey <casey@nrlssc.navy.mil>
Date: Jan 17, 2008, 01:49 UTC
Message-ID: <478EB430.1040604@nrlssc.navy.mil>
In-Reply-To: <7vir1tmey8.fsf@gitster.siamese.dyndns.org>

Junio C Hamano wrote:

Show 13 quoted lines

> Brandon Casey <casey@nrlssc.navy.mil> writes:
> 
>> Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
>> ---
>>
>>
>> Shouldn't we be doing this? I think if quiet is set,
>> then a failed rename will go undetected since we
>> won't enter print_summary to have lookup_commit fail.
> 
> But then it's a bit too late, isn't it?  We already have
> successfully made the commit and updated the HEAD to point at
> it.

Ok, so the commit has been made, but the index (since the rename failed), is out of sync?

>  We would need to tell the user that the index is not where
> it is when we detect the error, though.

The new index we are trying to rename will be deleted.
Are you saying we should 
  warn the user that the index is now out of sync?
  Or prevent the deletion of the updated index?
  or just ignore this case which I now see as very unlikely to occur?

-brandon