Re: [RFC] custom strategies in builtin-merge
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 26, 2008, 00:33 UTC
- Message-ID
- <7viqutpjqq.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <bd6139dc0807250450m25a932b8h68fcee13f8c343dc@mail.gmail.com>
"Sverre Rabbelier" <alturin@gmail.com> writes:
Show 15 quoted lines
> On Fri, Jul 25, 2008 at 13:33, Miklos Vajna <vmiklos@frugalware.org> wrote:
>> 1) Maintain a list of commands that has a git-merge- prefix, but not a
>> strategy. This list would currently contain "base, file, index,
>> one-file and tree".
>
> Sounds a bit error prone, and could lead to unexpected results if/when
> someone creates a new command ('git merge status' anyone?) which is
> then suddenly treated as a merge strategy.
>
>> 2) Require custom strategies to have a different naming scheme, like
>> if "foo" is a custom strategy, then it would have to be named
>> git-merge-custom-foo, _not_ git-merge-foo.
>
> I think this is cleaner, what would be even nicer is to change the
> current names too, so name them all "git-merge-stragegy-foo".I think you could retroactively impose "git-merge-strategy-" prefix rule and grandfather the existing ones by maintaining a list of them that by definition will not grow anymore.