Re: [PATCH] git send-email: edit recipient addresses with the --compose flag

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 9, 2008, 22:09 UTC
Message-ID: <7viqqwa6wo.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LFD.2.00.0811091344480.20499@sys-0.hiltweb.site>

Ian Hilt <ian.hilt@gmx.com> writes:

Show 17 quoted lines

> On Sun, 9 Nov 2008, Francis Galiegue wrote:
>> Le Sunday 09 November 2008 13:59:48 Ian Hilt, vous avez écrit :
>> > +	if ($c_file =~ /^To:\s*+(.+)\s*\nCc:/ism) {
>> 
>> Greedy operators are only supported with perl 5.10 or more... I think it's a 
>> bad idea to use them...
>
> The problem here was that a space should follow the field, but it may
> not.  The user may unwarily backup over it.  "\s*" would match this
> case.
>
> But if there is a space, it is included in the "(.+)".  So I tried
> "\s+", which did not include the space, but it won't include the first
> address if there isn't a space after the field.
>
> The quantified subpattern seemed to do the trick.  But, if it could
> result in a dependency issue, I would agree this would be a bad idea.

You expect something non-blank there anyway, so why not do:

	To:\s*(\S.*?)\s*\n....