Re: [PATCH] git send-email: edit recipient addresses with the --compose flag
- From
- Tait <git.git@t41t.com>
- Date
- Nov 11, 2008, 22:14 UTC
- Message-ID
- <20081111221421.GJ7408@ece.pdx.edu>
- In-Reply-To
- <alpine.LFD.2.00.0811111542230.24205@sys-0.hiltweb.site>
Show 29 quoted lines
> > > > > > + if ($c_file =~ /^To:\s*+(.+)\s*\nCc:/ism) {
> > > > >
> > > > > Greedy operators are only supported with perl 5.10 or more... I think
> > > > > it's a bad idea to use them...
> > > >
> > > > The problem here was that a space should follow the field, but it may
> > > > not. The user may unwarily backup over it. "\s*" would match this
> > > > case.
> > > >
> > > > But if there is a space, it is included in the "(.+)".
> > >
> > > Not in any version of Perl to which I have access.
> > >
> >
> > And if you see a space in (.+), your regex engine is buggy anyway.
>
> So what does this script produce on your systems?
>
> --8<--
> #!/usr/bin/perl -Tw
> use strict;
> my $ws = "To: \nCc:";
>
> $ws =~ /^To:\s*(.+)\s*\nCc:/ism;
>
> if ($1 eq ' ') {
> print "\$1 is equal to a space.\n";
> }
> -->8--It does match a space in that case. I misunderstood the problem this was trying to solve. (Sorry for the confusion.)