Re: [PATCH] git-remote.txt: fix wrong remote refspec

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 23, 2011, 05:35 UTC
Message-ID: <7viprx3yay.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1308804319-6354-1-git-send-email-namhyung@gmail.com>

Namhyung Kim <namhyung@gmail.com> writes:

Show 5 quoted lines

> $GIT_DIR/remotes/<name>/HEAD should be
> $GIT_DIR/refs/remotes/<name>/HEAD.
>
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
> ---

Obviously correct; thanks.

There is another questionable one you did not touch, though.

    With `-t <branch>` option, instead of the default glob
    refspec for the remote to track all branches under
    `$GIT_DIR/remotes/<name>/`, a refspec to track only `<branch>`
    is created.  You can give more than one `-t <branch>` to track
    multiple branches without grabbing all branches.

The above says "$GIT_DIR/remotes/<name>/", but it should say

    ... all branches under refs/remotes/<name>/ namespace,...

Also we should try to see if we can come up with a way to say the things the part your patch touched describe _without_ mentioning $GIT_DIR at all. "Store in $GIT_DIR/refs/$X" talks too much about the implementation detail that the ref in question is implemented as a loose ref. We would pack it into a single entry in $GIT_DIR/packed-refs file when we run gc, and at that point "$GIT_DIR/refs/$X" is no longer a correct description.