git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-remote.txt: fix wrong remote refspec

From
Namhyung Kim <namhyung@gmail.com>
Date
Jun 23, 2011, 06:17 UTC
Message-ID
<1308809849.1338.11.camel@leonhard>
In-Reply-To
<7viprx3yay.fsf@alter.siamese.dyndns.org>
Hello,
2011-06-22 (수), 22:35 -0700, Junio C Hamano:
Show 22 quoted lines
> Namhyung Kim <namhyung@gmail.com> writes:
> 
> > $GIT_DIR/remotes/<name>/HEAD should be
> > $GIT_DIR/refs/remotes/<name>/HEAD.
> >
> > Signed-off-by: Namhyung Kim <namhyung@gmail.com>
> > ---
> 
> Obviously correct; thanks.
> 
> There is another questionable one you did not touch, though.
> 
>     With `-t <branch>` option, instead of the default glob
>     refspec for the remote to track all branches under
>     `$GIT_DIR/remotes/<name>/`, a refspec to track only `<branch>`
>     is created.  You can give more than one `-t <branch>` to track
>     multiple branches without grabbing all branches.
> 
> The above says "$GIT_DIR/remotes/<name>/", but it should say
> 
>     ... all branches under refs/remotes/<name>/ namespace,...
> 
Oh, I didn't aware of that. Will send v2 soon.
Show 6 quoted lines
> Also we should try to see if we can come up with a way to say the things
> the part your patch touched describe _without_ mentioning $GIT_DIR at
> all. "Store in $GIT_DIR/refs/$X" talks too much about the implementation
> detail that the ref in question is implemented as a loose ref. We would
> pack it into a single entry in $GIT_DIR/packed-refs file when we run gc,
> and at that point "$GIT_DIR/refs/$X" is no longer a correct description.

I see. But I think it is a different issue and should be treated by another patch(es). Just omitting $GIT_DIR is not enough? I don't know :)

Thanks.
-- 
Regards,
Namhyung Kim
Previous: Junio C HamanoNext: Namhyung Kim
Message 3 of 16 in “git-remote.txt: fix wrong remote refspec”
  1. git-remote.txt: fix wrong remote refspecNamhyung Kim, Jun 23, 2011
  2. Junio C HamanoJun 23, 2011
  3. Namhyung KimJun 23, 2011
  4. git-remote.txt: fix wrong remote refspecNamhyung Kim, Jun 23, 2011
  5. Junio C HamanoJun 23, 2011
  6. Namhyung KimJun 23, 2011
  7. 0/5 Clarify "refs"Junio C Hamano, Jun 23, 2011
  8. 1/5 check-ref-format doc: de-emphasize the implementation detail of a refJunio C Hamano, Jun 23, 2011
  9. Eric SunshineJun 23, 2011
  10. 2/5 git.txt: de-emphasize the implementation detail of a refJunio C Hamano, Jun 23, 2011
  11. 3/5 glossary: update description of "tag"Junio C Hamano, Jun 23, 2011
  12. Eric SunshineJun 23, 2011
  13. 4/5 glossary: update description of head and refJunio C Hamano, Jun 23, 2011
  14. 5/5 glossary: clarify description of HEADJunio C Hamano, Jun 23, 2011
  15. Carlos Martín NietoJun 23, 2011
  16. Junio C HamanoJun 23, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.