git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] xdiff: remove unused functions

From
Junio C Hamano <gitster@pobox.com>
Date
May 9, 2012, 21:14 UTC
Message-ID
<7vipg5qcok.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4FAAD6F2.9050600@lsrfire.ath.cx>
René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
Show 7 quoted lines
> The functions xdl_cha_first(), xdl_cha_next() and xdl_atol() are not used
> by us.  While removing them increases the difference to the upstream
> version of libxdiff, it only adds a bit to the more than 600 differing
> lines in xutils.c (mmfile_t management was simplified significantly when
> the library was imported initially).  Besides, if upstream modifies these
> functions in the future, we won't need to think about importing those
> changes, so in that sense it makes tracking modifications easier.

I was of two minds wondering the exact pros-and-cons you described above, but OK, let's shrink it.

Previous: René Scharfe
Message 2 of 2 in “xdiff: remove unused functions”
  1. xdiff: remove unused functionsRené Scharfe, May 9, 2012
  2. Junio C HamanoMay 9, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.