From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 09 May 2012 21:14:51 GMT
Subject: Re: [PATCH] xdiff: remove unused functions
Message-ID: <7vipg5qcok.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4FAAD6F2.9050600@lsrfire.ath.cx>

René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:

> The functions xdl_cha_first(), xdl_cha_next() and xdl_atol() are not used
> by us.  While removing them increases the difference to the upstream
> version of libxdiff, it only adds a bit to the more than 600 differing
> lines in xutils.c (mmfile_t management was simplified significantly when
> the library was imported initially).  Besides, if upstream modifies these
> functions in the future, we won't need to think about importing those
> changes, so in that sense it makes tracking modifications easier.

I was of two minds wondering the exact pros-and-cons you described above,
but OK, let's shrink it.