git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff: exit(1) if 'diff --quiet <repo file> <external file>' finds changes

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 15, 2012, 20:10 UTC
Message-ID
<7vipes9w0p.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CAFoueth2Hfcv0p0SZmichi_6e5--SNkemrSsSivnU73bdFOB4g@mail.gmail.com>
Tim Henigan <tim.henigan@gmail.com> writes:
> I will send v2 with the change to 'diff-no-index.c' suggested by
> Junio.  I will also include the 'test_expect_code' improvement
> suggested by Jeff.

Also the test script shouldn't be just testing a simplest case, I would think.

For example, comparing two files with "a b c" and "a b c" in them with "--quiet" should yield "They are different!" while running the same comparison with "--quiet -w" should say "They are the same!", no?

Previous: Junio C HamanoNext: Tim Henigan
Message 10 of 12 in “diff: exit(1) if 'diff --quiet <repo file> <external file>' finds changes”
  1. diff: exit(1) if 'diff --quiet <repo file> <external file>' finds changesTim Henigan, Jun 15, 2012
  2. Jeff KingJun 15, 2012
  3. Jeff KingJun 15, 2012
  4. Junio C HamanoJun 15, 2012
  5. Jeff KingJun 15, 2012
  6. Tim HeniganJun 15, 2012
  7. Junio C HamanoJun 15, 2012
  8. Jeff KingJun 15, 2012
  9. Junio C HamanoJun 15, 2012
  10. Junio C HamanoJun 15, 2012
  11. Tim HeniganJun 18, 2012
  12. Junio C HamanoJun 18, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.