From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 15 Jun 2012 20:10:14 GMT
Subject: Re: [PATCH] diff: exit(1) if 'diff --quiet <repo file> <external file>' finds changes
Message-ID: <7vipes9w0p.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAFoueth2Hfcv0p0SZmichi_6e5--SNkemrSsSivnU73bdFOB4g@mail.gmail.com>

Tim Henigan <tim.henigan@gmail.com> writes:

> I will send v2 with the change to 'diff-no-index.c' suggested by
> Junio.  I will also include the 'test_expect_code' improvement
> suggested by Jeff.

Also the test script shouldn't be just testing a simplest case, I
would think.

For example, comparing two files with "a b c" and "a  b c" in them
with "--quiet" should yield "They are different!" while running the
same comparison with "--quiet -w" should say "They are the same!",
no?