Re: [PATCH] am: quote string for translation before passing to eval_gettextln

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 22, 2012, 19:38 UTC
Message-ID: <7vipca7m4q.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1345646883-18746-1-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:

Show 9 quoted lines

> If it's not quoted, the string is expanded before it gets looked up in
> gettext database and obviously nothing is returned.
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
> ...
>  Yep. Verified. Also checked that no other places have this problem.
>  xgettext probably detects this too. Without this patch it does not
>  collect this string. With this patch, it does.

Will queue; thanks.

Show 19 quoted lines

>
>  git-am.sh | 4 ++--
>  1 tập tin đã bị thay đổi, 2 được thêm vào(+), 2 bị xóa(-)
>
> diff --git a/git-am.sh b/git-am.sh
> index bd9620c..c682d34 100755
> --- a/git-am.sh
> +++ b/git-am.sh
> @@ -855,8 +855,8 @@ did you forget to use 'git add'?"
>  		eval_gettextln 'Patch failed at $msgnum $FIRSTLINE'
>  		if test "$(git config --bool advice.amworkdir)" != false
>  		then
> -			eval_gettextln "The copy of the patch that failed is found in:
> -   $dotest/patch"
> +			eval_gettextln 'The copy of the patch that failed is found in:
> +   $dotest/patch'
>  		fi
>  		stop_here_user_resolve $this
>  	fi