[PATCH] am: quote string for translation before passing to eval_gettextln
- From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
- Date
- Aug 22, 2012, 14:48 UTC
- Message-ID
- <1345646883-18746-1-git-send-email-pclouds@gmail.com>
- In-Reply-To
- <20120822141726.GA674@mannheim-rule.local>
If it's not quoted, the string is expanded before it gets looked up in gettext database and obviously nothing is returned.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> --- On Wed, Aug 22, 2012 at 9:17 PM, Jonathan Nieder <jrnieder@gmail.com> wrote: > Nguyen Thai Ngoc Duy wrote: > >> which means git performed a lookup on that string. It is from git-am.sh: >> >> eval_gettextln "The copy of the patch that failed is found in: >> $dotest/patch" > > Good catch. It should use single-quotes.
Yep. Verified. Also checked that no other places have this problem. xgettext probably detects this too. Without this patch it does not collect this string. With this patch, it does.
git-am.sh | 4 ++-- 1 tập tin đã bị thay đổi, 2 được thêm vào(+), 2 bị xóa(-)
diff --git a/git-am.sh b/git-am.sh index bd9620c..c682d34 100755 --- a/git-am.sh +++ b/git-am.sh @@ -855,8 +855,8 @@ did you forget to use 'git add'?" eval_gettextln 'Patch failed at $msgnum $FIRSTLINE' if test "$(git config --bool advice.amworkdir)" != false then - eval_gettextln "The copy of the patch that failed is found in: - $dotest/patch" + eval_gettextln 'The copy of the patch that failed is found in: + $dotest/patch' fi stop_here_user_resolve $this fi
-- 1.7.12.rc2.18.g61b472e