Re: git format-patch shell quoting bug

From: Junio C Hamano <junkio@cox.net>
Date: Jan 7, 2006, 02:38 UTC
Message-ID: <7vhd8gpxt3.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060104045519.GB29515@quicksilver.road.mcmartin.ca>

Kyle McMartin <kyle@mcmartin.ca> writes:

Show 8 quoted lines

> There's apparently a quoting bug in git-format-patch. When I import
> a patch with apply-mbox, for example
>
> From: Carlos O'Donell <carlos@parisc-linux.org>
>
> The author field is correctly set, including the "'" in Carlos' name.
> ...
> I believe this recently crept in, as I don't recall seeing it before.

Thanks for spotting this.

There was a similar problem with "git-commit -c". I think I got both of them right with commit aa66c7:

    commit aa66c7ec77d474b737da607d6cb2d07f56628def
    Author: Junio C Hamano <junkio@cox.net>
    Date:   Thu Jan 5 19:50:37 2006 -0800

        format-patch/commit: Quote single quote in the author name properly.

        Noticed by Kyle McMartin.

        Signed-off-by: Junio C Hamano <junkio@cox.net>

The bug was present ever since format-patch started picking up the original authorship information from the commits, done on July 22nd last year, between v0.99.1 and v0.99.2.