git/list[1] front-page[2] threads[3] people[4] search[5] about
 

git format-patch shell quoting bug

From
Kyle McMartin <kyle@mcmartin.ca>
Date
Jan 4, 2006, 04:55 UTC
Message-ID
<20060104045519.GB29515@quicksilver.road.mcmartin.ca>
Hi,

There's apparently a quoting bug in git-format-patch. When I import a patch with apply-mbox, for example

From: Carlos O'Donell <carlos@parisc-linux.org>
The author field is correctly set, including the "'" in Carlos' name.

So when I go to rebase my tree, or send out patches, I "git-format-patch origin" and get...

/usr/bin/git-format-patch: eval: line 200: unexpected EOF while looking for matching `'' /usr/bin/git-format-patch: eval: line 201: syntax error: unexpected end of file

Which produces a bogus output patch with a blank From and Date,
Subject: [PATCH] ...
From:
Date:
[...]
I believe this recently crept in, as I don't recall seeing it before.
Cheers,
	Kyle
Next: Junio C Hamano
Message 1 of 3 in “git format-patch shell quoting bug”
  1. Kyle McMartinJan 4, 2006
  2. Junio C HamanoJan 7, 2006
  3. Kyle McMartinJan 7, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.