Re: [PATCH] Reintroduce svn pools to solve the memory leak.

From: Junio C Hamano <junkio@cox.net>
Date: Mar 27, 2006, 18:16 UTC
Message-ID: <7vhd5joiqt.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <8aa486160603270326i3a8ddcfau61ca84cdac036ff9@mail.gmail.com>

"Santi Béjar" <sbejar@gmail.com> writes:

Show 18 quoted lines

> On 3/24/06, Santi Béjar <sbejar@gmail.com> wrote:
>> Jan-Benedict Glaw <jbglaw@lug-owl.de> writes:
>>
>> diff-tree 4802426... (from 525c0d7...)
>> Author: Karl  Hasselström <kha@treskal.com>
>> Date:   Sun Feb 26 06:11:27 2006 +0100
>>
>>     svnimport: Convert executable flag
>>
>>     Convert the svn:executable property to file mode 755 when converting
>>     an SVN repository to GIT.
>>
>>     Signed-off-by: Karl Hasselström <kha@treskal.com>
>>     Signed-off-by: Junio C Hamano <junkio@cox.net>
>>
>> :100755 100755 ee2940f... 6603b96... M  git-svnimport.perl
>
> And this patch fixes my problems.

Jan-Benedict, thanks for pinpointing the regression, and Santi, thanks for the patch.

I should have looked a bit more closely when applying the patch -- it is clear that the patch is doing more than what its log says. My fault.

Karl, were there other reasons you needed to disable the pool here (maybe to work around a problem with incompatible version of SVN module)? I see some other uses of SVN::Pool still there in the code, so I am assuming this was a simple typo, but just in case...