Re: [PATCH 4/n] gitweb: Secure against commit-ish/tree-ish with the same name as path

From: Junio C Hamano <junkio@cox.net>
Date: Nov 3, 2006, 06:18 UTC
Message-ID: <7vhcxhjbog.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200611020949.34276.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

Show 14 quoted lines

> Junio C Hamano wrote:
>
>> I'll be pushing out a "master" update
>> sometime today, and do not expect to be able to get to your "n
>> turned out to be ten" series, so it might be worthwhile to
>> reroll the remaining bits that you still care about on top of
>> what I push out tonight to make sure we are on the same page.
>
> I'll wait a while if there are any comments (for example on formatting
> used), and resend cleaned-up series.
> ...
> I've send series early to get some comments, but I see while I got
> some comments on "take 1" and "take 2" on _single_ "new commitdiff"
> RFC patch, I got comments only about half-baked '&iquot;' idea.

Well, I think some of the major reasons you did not get any response were:

 (1) it was unclear where it started, where it was heading to,
     and where it ended until you sent out "by the way n=10"
     message at the end;

 (2) the first major oand interesting one in the series (5/n)
     were linewrapped and could not be applied;

and it is rather hard to comment on gitweb changes unless you view two instances of gitweb output side-by-side for before and after each patch.

I'd see if I can add some constructive comments on patches 5-10 tonight, but I'm in the middle of other things so don't hold your breath ;-).