Re: [PATCH 2/n] gitweb: Use '&iquot;' instead of '?' in esc_path

From: Junio C Hamano <junkio@cox.net>
Date: Nov 7, 2006, 22:18 UTC
Message-ID: <7v64dq3nq7.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200611072253.34291.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

Show 5 quoted lines

> I don't think it would be good idea to separate unquote correction with 
> esc_path work, because havin unquote which unquotes fully means that we 
> can have filenames which have for exampl newline characters in them, 
> hence the need of separate quoting subroutine, esc_path, and using it 
> for filename escaping.

Yeah, I think that makes sense.

No matter what escaping we would end up picking in the second part, we should do the unquote plus esc_path anyway, so I think a two patch series to replace to '?' first and then pretty-print that '?' with whatever encoding and span.cntrl is a very sensible way to go.

As to backslash, cute control pictures and just plain '?', I do not have a strong preference among them. Especially if you have the span.cntrl around them, we can tell even a plain '?' from the substitution of funny byte values, so it probably is just a matter of taste and I'd leave that up to you and gitweb cabal on the list ;-).