git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff-delta: use realloc instead of xrealloc

From
Junio C Hamano <junkio@cox.net>
Date
May 30, 2007, 06:17 UTC
Message-ID
<7vhcpu4yzm.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<alpine.LFD.0.99.0705292252220.11491@xanadu.home>
Nicolas Pitre <nico@cam.org> writes:
Show 6 quoted lines
> On Tue, 29 May 2007, Junio C Hamano wrote:
>
>> Wasn't there a discussion around this exact issue when the
>> original patch was applied?
>
> Maybe, but I cannot remember it, not can I justify that xrealloc now.
Actually, the discussion was older than the patch.
    http://thread.gmane.org/gmane.comp.version-control.git/43766/focus=43783

And I myself suggested to use non x- variant of allocation routines in diff-delta.c as the callers know how to handle near oom condition ;-).

Previous: Nicolas Pitre
Message 4 of 4 in “diff-delta: use realloc instead of xrealloc”
  1. diff-delta: use realloc instead of xreallocMartin Koegler, May 29, 2007
  2. Junio C HamanoMay 29, 2007
  3. Nicolas PitreMay 30, 2007
  4. Junio C HamanoMay 30, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.