From: Junio C Hamano Date: Wed, 30 May 2007 06:17:01 GMT Subject: Re: [PATCH] diff-delta: use realloc instead of xrealloc Message-ID: <7vhcpu4yzm.fsf@assigned-by-dhcp.cox.net> In-Reply-To: Nicolas Pitre writes: > On Tue, 29 May 2007, Junio C Hamano wrote: > >> Wasn't there a discussion around this exact issue when the >> original patch was applied? > > Maybe, but I cannot remember it, not can I justify that xrealloc now. Actually, the discussion was older than the patch. http://thread.gmane.org/gmane.comp.version-control.git/43766/focus=43783 And I myself suggested to use non x- variant of allocation routines in diff-delta.c as the callers know how to handle near oom condition ;-).