git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rev-list --bisect: Fix best == NULL case.

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 20, 2007, 07:08 UTC
Message-ID
<7vhclplsq7.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<7vmyvhltpy.fsf@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 6 quoted lines
> The patch makes sense.  In fact you can crash any released
> version like this:
>
>     $ git rev-list --bisect v1.5.2..v1.5.0
>
> I'll need to apply a moral equivalent to 'maint'.
I spoke too fast.  This is not broken in any released version.

Only with the patch from somebody that broke it with commit ce0cbad7727457854d631a6314d9aee7c837cb65 (rev-list --bisect: Move finding bisection into do_find_bisection.), the "empty set" case would segfault ;-).

Previous: Junio C Hamano
Message 3 of 3 in “rev-list --bisect: Fix best == NULL case.”
  1. rev-list --bisect: Fix best == NULL case.Christian Couder, Sep 20, 2007
  2. Junio C HamanoSep 20, 2007
  3. Junio C HamanoSep 20, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.