From: Junio C Hamano Date: Thu, 20 Sep 2007 07:08:00 GMT Subject: Re: [PATCH] rev-list --bisect: Fix best == NULL case. Message-ID: <7vhclplsq7.fsf@gitster.siamese.dyndns.org> In-Reply-To: <7vmyvhltpy.fsf@gitster.siamese.dyndns.org> Junio C Hamano writes: > The patch makes sense. In fact you can crash any released > version like this: > > $ git rev-list --bisect v1.5.2..v1.5.0 > > I'll need to apply a moral equivalent to 'maint'. I spoke too fast. This is not broken in any released version. Only with the patch from somebody that broke it with commit ce0cbad7727457854d631a6314d9aee7c837cb65 (rev-list --bisect: Move finding bisection into do_find_bisection.), the "empty set" case would segfault ;-).