git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] git-fetch: avoid local fetching from alternate (again)

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 8, 2007, 10:07 UTC
Message-ID
<7vhcjx2gq5.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20071108100039.GM14735@spearce.org>
"Shawn O. Pearce" <spearce@spearce.org> writes:
Show 8 quoted lines
> I'm starting to suspect heap corruption again in builtin-fetch.
> This patch alters the malloc() calls we are doing and may be shifting
> something around just enough in memory to cause a data overwrite or
> something and that's why this tag just drops out of the linked list?
> But then why does that happen in the test suite but not outside.
> Maybe because the test suite is setting environment variables that
> I'm not and the impact of those combined with these additional
> mallocs is what is breaking it?  *sigh*
Thanks for working hard on this one.

It is starting to look like today was "let's kill other people's bugs" day. I'd go to bed before I completely miss sleep, which I often end up doing when thinking too long about bugs.

Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 3 of 5 in “git-fetch: avoid local fetching from alternate (again)”
  1. 3/3 git-fetch: avoid local fetching from alternate (again)Shawn O. Pearce, Nov 8, 2007
  2. Shawn O. PearceNov 8, 2007
  3. Junio C HamanoNov 8, 2007
  4. Shawn O. PearceNov 8, 2007
  5. Shawn O. PearceNov 8, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.