From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 08 Nov 2007 10:07:14 GMT
Subject: Re: [PATCH 3/3] git-fetch: avoid local fetching from alternate (again)
Message-ID: <7vhcjx2gq5.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20071108100039.GM14735@spearce.org>

"Shawn O. Pearce" <spearce@spearce.org> writes:

> I'm starting to suspect heap corruption again in builtin-fetch.
> This patch alters the malloc() calls we are doing and may be shifting
> something around just enough in memory to cause a data overwrite or
> something and that's why this tag just drops out of the linked list?
> But then why does that happen in the test suite but not outside.
> Maybe because the test suite is setting environment variables that
> I'm not and the impact of those combined with these additional
> mallocs is what is breaking it?  *sigh*

Thanks for working hard on this one.

It is starting to look like today was "let's kill other people's
bugs" day.  I'd go to bed before I completely miss sleep, which
I often end up doing when thinking too long about bugs.