git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] builtin-tag.c: use valid_ident for checking tagger field

From
Junio C Hamano <junio@pobox.com>
Date
May 11, 2008, 18:39 UTC
Message-ID
<7vhcd43csh.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<9526336.1210309346451.JavaMail.teamon@b304.teamon.com>
drafnel@gmail.com writes:
Show 20 quoted lines
> From: Brandon Casey <drafnel@gmail.com>
>
> Use valid_ident function for validating the tagger field
> in generated tags rather than a tag specific version.
>
> Also update tests.
>
> Signed-off-by: Brandon Casey <drafnel@gmail.com>
> ---
>  builtin-tag.c    |   39 +++++----------------------------------
>  t/t3800-mktag.sh |   14 +++++++-------
>  2 files changed, 12 insertions(+), 41 deletions(-)
>
> diff --git a/builtin-tag.c b/builtin-tag.c
> index 0f79d47..2dcb795 100644
> --- a/builtin-tag.c
> +++ b/builtin-tag.c
> @@ -339,8 +339,7 @@ static int verify_tag_buffer(const char *buffer, size_t size)
>  	int typelen;
>  	char type[20];
Funny.
This [2/2] seems to depend on [3/5] that renames verify_tag to verify_tag_buffer().
What is going on?
Previous: drafnel@gmail.comNext: Brandon Casey
Message 2 of 3 in “builtin-tag.c: use valid_ident for checking tagger field”
  1. 2/2 builtin-tag.c: use valid_ident for checking tagger fielddrafnel@gmail.com, May 9, 2008
  2. Junio C HamanoMay 11, 2008
  3. Brandon CaseyMay 12, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.