From: Junio C Hamano <junio@pobox.com>
Date: Sun, 11 May 2008 18:39:58 GMT
Subject: Re: [PATCH 2/2] builtin-tag.c: use valid_ident for checking tagger field
Message-ID: <7vhcd43csh.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <9526336.1210309346451.JavaMail.teamon@b304.teamon.com>

drafnel@gmail.com writes:

> From: Brandon Casey <drafnel@gmail.com>
>
> Use valid_ident function for validating the tagger field
> in generated tags rather than a tag specific version.
>
> Also update tests.
>
> Signed-off-by: Brandon Casey <drafnel@gmail.com>
> ---
>  builtin-tag.c    |   39 +++++----------------------------------
>  t/t3800-mktag.sh |   14 +++++++-------
>  2 files changed, 12 insertions(+), 41 deletions(-)
>
> diff --git a/builtin-tag.c b/builtin-tag.c
> index 0f79d47..2dcb795 100644
> --- a/builtin-tag.c
> +++ b/builtin-tag.c
> @@ -339,8 +339,7 @@ static int verify_tag_buffer(const char *buffer, size_t size)
>  	int typelen;
>  	char type[20];

Funny.

This [2/2] seems to depend on [3/5] that renames verify_tag to verify_tag_buffer().

What is going on?