git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Update packfile transfer protocol documentation

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 2, 2009, 17:31 UTC
Message-ID
<7vhbtcvnoo.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20091102154104.GR10505@spearce.org>
"Shawn O. Pearce" <spearce@spearce.org> writes:
Show 9 quoted lines
> If its SHA-1 you are talking about, I wanted this to be a MUST
> use lowercase, but people screamed about it (Jakub and Ilari
> IIRC).  The current C code accepts uppercase due to its use of
> get_sha1_hex(), and they wanted to follow the "be liberal in what
> you accept" suggestion from other IETF authors.
>
> IIRC, all implementations use lowercase.  We should be able to safely
> say MUST produce lowercase, and MUST accept lowercase, and SHOULD
> NOT accept uppercase,...

I do not see a point in loosening or tightening the definition document that is written to describe a protocol of a reference implementation after the fact. It is not like producing lowercase hexdegits is a lot more work on some weird platforms.

Everybody writes in lowercase, expects to see lowercase, and some may accept uppercase by accident. I think it is acceptable to describe that as "MUST produce, MUST accept lc and MAY accept uc", but I do not think it is even necessary to specifically say "and MAY accept uc".

It is actively wrong to say "SHOULD NOT accept uc"---it won't help anybody.

Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 4 of 16 in “Update packfile transfer protocol documentation”
  1. Update packfile transfer protocol documentationScott Chacon, Nov 1, 2009
  2. Junio C HamanoNov 2, 2009
  3. Shawn O. PearceNov 2, 2009
  4. Junio C HamanoNov 2, 2009
  5. Shawn O. PearceNov 2, 2009
  6. Junio C HamanoNov 2, 2009
  7. Shawn O. PearceNov 2, 2009
  8. Junio C HamanoNov 3, 2009
  9. Shawn O. PearceNov 3, 2009
  10. Scott ChaconNov 3, 2009
  11. Junio C HamanoNov 4, 2009
  12. Junio C HamanoNov 4, 2009
  13. Shawn O. PearceNov 4, 2009
  14. Junio C HamanoNov 4, 2009
  15. Shawn O. PearceNov 4, 2009
  16. Junio C HamanoNov 4, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.