Re: [PATCH] Do not install shell libraries executable

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 31, 2010, 07:08 UTC
Message-ID: <7vhbq2g3a9.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20100129145025.GA22703@progeny.tock>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 13 quoted lines

> @@ -1488,6 +1490,15 @@ $(patsubst %.sh,%,$(SCRIPT_SH)) : % : %.sh
>  	chmod +x $@+ && \
>  	mv $@+ $@
>  
> +$(patsubst %.sh,%,$(SCRIPT_LIB_SH)) : % : %.sh
> +	$(QUIET_GEN)$(RM) $@ $@+ && \
> +	sed -e 's|@SHELL_PATH@|$(SHELL_PATH_SQ)|' \
> +	    -e 's/@@GIT_VERSION@@/$(GIT_VERSION)/g' \
> +	    -e 's/@@NO_CURL@@/$(NO_CURL)/g' \
> +	    -e $(BROKEN_PATH_FIX) \
> +	    $@.sh >$@+ && \
> +	mv $@+ $@
> +

Can't you do something about this repetition from existing $(SCRIPT_SH) munging? Other than that the patch looks like Ok.