git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] valgrind bug roundup

From
Jeff King <peff@peff.net>
Date
Jan 29, 2010, 10:25 UTC
Message-ID
<20100129102518.GA5875@coredump.intra.peff.net>
In-Reply-To
<20100128145216.GA29727@coredump.intra.peff.net>
On Thu, Jan 28, 2010 at 09:52:16AM -0500, Jeff King wrote:
> I'm running the whole test suite under valgrind for the current
> 'master'. This was the first hit, but it's very s-l-o-w, so there might
> be more as the day progresses.

And here they are. The first two are actual bugs, the third silences a false positive:

  [1/3]: fix memcpy of overlapping area
  [2/3]: fix off-by-one allocation error
  [3/3]: add shebang line to git-mergetool--lib.sh

It really has been a while since I've run the whole test suite under valgrind. The breakage in 3/3 dates back to last April. The bug in 1/3 is also quite old (v1.5.0). I'm not sure why I didn't find it in previous valgrind runs; perhaps it is only recent valgrinds that have grown support for finding overlapping memcpy. The bug in 2/3 is new, and has never been in a released version.

-Peff
Previous: Jeff KingNext: Jeff King
Message 2 of 13 in “rerere: fix too-short initialization”
  1. rerere: fix too-short initializationJeff King, Jan 28, 2010
  2. 0/3 valgrind bug roundupJeff King, Jan 29, 2010
  3. 1/3 fix memcpy of overlapping areaJeff King, Jan 29, 2010
  4. 2/3 fix off-by-one allocation errorJeff King, Jan 29, 2010
  5. 3/3 add shebang line to git-mergetool--lib.shJeff King, Jan 29, 2010
  6. Do not install shell libraries executableJonathan Nieder, Jan 29, 2010
  7. Junio C HamanoJan 31, 2010
  8. Do not install shell libraries executableJonathan Nieder, Jan 31, 2010
  9. Junio C HamanoJan 31, 2010
  10. Jonathan NiederJan 31, 2010
  11. Junio C HamanoJan 31, 2010
  12. Jonathan NiederJan 31, 2010
  13. Junio C HamanoJan 31, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.